Skip to content

backport fix to 252-patch download site bundle correctly if site name has special chars #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 17, 2024
Merged

backport fix to 252-patch download site bundle correctly if site name has special chars #270

merged 5 commits into from
Dec 17, 2024

Conversation

pulkit0555
Copy link
Contributor

What does this PR do?

Fixes the bug when site name contains special chars and we need to download site bundle

What issues does this PR fix or reference?

@W-17310811@

pulkit0555 and others added 2 commits November 25, 2024 22:15
@pulkit0555 @nrkruk
fix: download site bundle correctly if site name has special chars (#262
8079b84 
)

* fix: updated special chars in site name

* fix: minor fix

* fix: refactored code

* chore: change test naming

---------

Co-authored-by: Nicolas Kruk <nicolaskruk@gmail.com>
Co-authored-by: Nicolas Kruk <nkruk@salesforce.com>
@pulkit0555
fix: added yarn version 1
0b3d6d2
@pulkit0555 pulkit0555 self-assigned this Nov 25, 2024
@pulkit0555 pulkit0555 requested a review from a team as a code owner November 25, 2024 17:18
@nrkruk nrkruk merged commit d9437ac into 252-patch Dec 17, 2024
15 checks passed
@nrkruk nrkruk deleted the pjain/siteBundleFixBackport branch December 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrkruk nrkruk nrkruk approved these changes

Assignees

@pulkit0555 pulkit0555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulkit0555 @nrkruk @svc-cli-bot